client: add a BTC exchange wallet #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
commented
Nov 9, 2019
buck54321
commented
Nov 9, 2019
client/asset/interface.go
Outdated
| // looking for the maker's redemption beginning at swapconf confirmations | ||
| // (at the latest) regardless of whether the server sends the 'redemption' | ||
| // message or not. | ||
| FindRedemption(ctx context.Context, txid string, vout uint32) (dex.Bytes, error) |
There was a problem hiding this comment.
In all wallet implementations, this method will need extra scrutiny. It should be impossible for someone to spend the swap output in such a way as to make this function fail.
dnldd
reviewed
Nov 9, 2019
buck54321
force-pushed
the
btcwallet
branch
3 times, most recently
from
a763daf
to
86344cf
Compare
buck54321
force-pushed
the
btcwallet
branch
5 times, most recently
from
e384bdd
to
110886b
Compare
|
There was some matrix discussion about using simnet instead of regnet. I failed to remember at the time, but bitcoind has no simnet. |
|
Sounds like regnet will be the only option for rapid simulations with BTC then. Using this in market pairs with DCR simnet should then be permitted (i.e. only require a mainnet asset be paired with another mainnet asset). |
A wallet interface is developed along with the wallet functionality needed for BTC, and likely a few clones. To avoid the need to run a btcd node or to rewrite an RPC client from scratch, a compromise is made to use btcd's rcpclient.Client for all RPC calls, but with wallet-related calls routed through the RawRequest method and parsed independently. The wallet interface offered here is intended to be somewhat abstract, with language such as "utxos", "txid", and "vout" traded for more generalized terms such as "coins", "id", and "index". I believe this makes the interface more flexible and keeps the client implementation independent of the underlying blockchain specifics.
chappjc
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A DEX wallet interface and BTC implementation. To avoid the need to run a btcd node or to rewrite an RPC client from scratch, a compromise
is made to use btcd's
rcpclient.Clientfor all RPC calls, but with wallet-related calls routed through theRawRequestmethod and parsed independently.The wallet interface offered here is intended to be somewhat abstract, with language such as "utxos", "txid", and "vout" traded for more generalized terms such as "coins", "id", and "index". I
believe this makes the interface more flexible and keeps the client implementation independent of the underlying blockchain specifics.