server/swap: avoid deadlock with maker redeem ack #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting a match after receiving the maker's redeem ack (of the taker's redeem), do not violate established lock ordering of Swapper.matchMtx and matchTracker.mtx. This deals with the matchMtx prior to locking the matchTracker, avoiding a possible deadlock with another goroutine locking these.
JoeGruffins
approved these changes
Jan 4, 2023
buck54321
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the deadlock observed in https://github.com/decred/dcrdex/actions/runs/3824469529/jobs/6506641057#step:5:1100