server: allow server operators to provide custom logo #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
reviewed
Dec 20, 2022
ukane-philemon
force-pushed
the
serverlogo
branch
from
71480fc
to
c192675
Compare
martonp
reviewed
Dec 21, 2022
ukane-philemon
commented
Dec 22, 2022
buck54321
reviewed
Jan 2, 2023
buck54321
reviewed
Jan 2, 2023
chappjc
reviewed
Jan 2, 2023
|
Something weird went off here. |
|
Resolving that unrelated Swapper deadlock in #2021 |
ukane-philemon
force-pushed
the
serverlogo
branch
2 times, most recently
from
90900d4
to
19a8154
Compare
buck54321
requested changes
Jan 8, 2023
ukane-philemon
force-pushed
the
serverlogo
branch
from
19a8154
to
a3ebb22
Compare
buck54321
requested changes
Jan 24, 2023
chappjc
reviewed
Jan 24, 2023
buck54321
reviewed
Jan 27, 2023
ukane-philemon
force-pushed
the
serverlogo
branch
from
2ff70bd
to
2cb08b8
Compare
|
Had to squash the multiple commits. |
buck54321
approved these changes
Jan 27, 2023
ukane-philemon
force-pushed
the
serverlogo
branch
from
2cb08b8
to
f77b43d
Compare
|
Just rebased..... |
ukane-philemon
force-pushed
the
serverlogo
branch
from
f77b43d
to
db45ad4
Compare
|
Will review. Please rebase again when you get a chance. |
ukane-philemon
force-pushed
the
serverlogo
branch
from
db45ad4
to
4c19c11
Compare
Done. |
chappjc
reviewed
Apr 11, 2023
Signed-off-by: Philemon Ukane <[email protected]>
|
This PR needs another advocate. There is no point to this in the future and it adds a lot of baggage. |
|
Closing tomorrow. |
|
It just doesn't make sense to do this anymore now that we're focusing on mesh. Thanks for the effort @ukane-philemon. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible for server operators to specify their custom logos. Closes #1256
-- Add new server HTTP
logoendpoint.-- Add server custom logo to config response.
Added logo display on the
settingsanddexsettingspages. Will it look better if the logos had a rounded border?