certgen: Support Ed25519 cert generation on Go 1.13 #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the function NewEd25519TLSCertPair which uses Ed25519 keys rather than ECDSA keys as required by NewTLSCertPair. Conditional compilation is used to provide the function only on Go 1.13.
|
There is quite a bit of copied code between the ECDSA and Ed25519 implementations, so here is the diff: https://gist.github.com/jrick/d30e1f7ced5e8d35656da1f11de5a089 |
davecgh
requested changes
Jun 7, 2019
davecgh
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the function NewEd25519TLSCertPair which uses Ed25519 keys
rather than ECDSA keys as required by NewTLSCertPair.
Conditional compilation is used to provide the function only on Go 1.13.
Closes #1756.