Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certgen: Support Ed25519 keys #1756

Closed
jrick opened this issue Jun 7, 2019 · 0 comments · Fixed by #1757
Closed

certgen: Support Ed25519 keys #1756

jrick opened this issue Jun 7, 2019 · 0 comments · Fixed by #1757

Comments

@jrick
Copy link
Member

jrick commented Jun 7, 2019

For decred/dcrwallet#1475 (and presumably dcrd too) we wish to support Ed25519 keys in TLS certificates. Currently, certgen exposes the function:

func NewTLSCertPair(curve elliptic.Curve, organization string, validUntil time.Time, extraHosts []string) (cert, key []byte, err error) {

which is not suitable for other signature schemes other than ECDSA.

Either a breaking change is necessary (to pass a private key as crypto.Signer and switch on its type) or a new API is needed in order to enable support for Ed25519 keys.

crypto/tls enables Ed25519 support in Go 1.13 so conditional compilation is necessary to not break the 1.12 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant