-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve navigation and filters in proposals #13004
Improve navigation and filters in proposals #13004
Conversation
decidim-admin/app/views/decidim/admin/shared/_adjacents_navigation.html.erb
Fixed
Show fixed
Hide fixed
decidim-admin/app/views/decidim/admin/shared/_adjacents_navigation.html.erb
Fixed
Show fixed
Hide fixed
decidim-admin/app/views/decidim/admin/shared/_adjacents_navigation.html.erb
Fixed
Show fixed
Hide fixed
decidim-admin/app/views/decidim/admin/shared/_adjacents_navigation.html.erb
Fixed
Show fixed
Hide fixed
decidim-admin/app/views/decidim/admin/shared/_adjacents_navigation.html.erb
Fixed
Show fixed
Hide fixed
decidim-admin/app/views/decidim/admin/shared/_adjacents_navigation.html.erb
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']
@NilHomedes we are fixing the button separation, but meanwhile you can test the rest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @furilo
First of all, please ask me for a review once you have finished all the job.
If not, I'm wasting time reviewing something that suddenly changes, as just happened. I'm saying that for the red colour of the button.
Anyway, just two small changes we should make:
- Change the text to "Remove all"
- Add bold to the "Remove all" text
Changes added and updated screenshots |
This reverts commit 495a33b.
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
a4bb05b
to
9ab95a0
Compare
Done |
* Store filters selections in session and allow removing all filters * Implement next and prev links from proposal show * Inspect session * Use with_indifferent_access with session admin_filters * Revert "Inspect session" This reverts commit 495a33b. * Refactor adjacents navigation links * Use spans and adjust margins * Fix wrong spelling * Fix spelling * Ensure the session filtered collection query returns an id * style filters bar * better space handling for containers * Add tests * Change remove all filters text * Remove font-normal class remove all filters tag * Fix expected text in tests * Add comment to adjacent_items method * Move method call to before_action filter * Define index method explicitly in controller * Change translation Co-authored-by: Andrés Pereira de Lucena <[email protected]> * Remove unnecessary method call Co-authored-by: Andrés Pereira de Lucena <[email protected]> --------- Co-authored-by: Hugoren Martinako <[email protected]> Co-authored-by: Andrés Pereira de Lucena <[email protected]> (cherry picked from commit 49bd028)
🎩 What? Why?
This PR:
check_admin_session_filters
method defined in the filterable concern which has been added only to proposals index, but it can be used in other indexes with filters of the admin panel to keep the filters choices📌 Related Issues
Link your PR to an issue
Testing
As admin:
Visit the index of a proposals component: https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/4/manage/proposals
Check some filters: The URL should change accordingly including the selected filters. If there are more than one checked filter an option to remove all filters appears: https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/4/manage/proposals?q%5Bis_emendation_true%5D=false&q%5Bwith_any_state%5D=state_not_published
Visit an item of the filtered list. A previous and / or next links should appear including items of the filtered list. https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/4/manage/proposals/7
Go back to the proposals index: https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/4/manage/proposals. The previously selected filters should appear and the application should redirect to the path including the filters