Backport 'Don't allow access to admin panel without ToS acceptance' to v0.27 #11042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
backport
alecslupu
force-pushed
the
backport/0.27/dont-allow-access-to-admin-pan-10117
branch
3 times, most recently
from
346ed3f to
97edc4c
Compare
* Don't allow access to admin panel without ToS acceptance * Add redirection to previous page after accepting ToS * Use have_content instead of have_text * Running spellcheck linters * Fix specs * Fix permissions on Templates when user is not admin * Fix specs * Fix i18n string scope from merge * Workaround for admin ToS acceptance in Initiatives After #5736, the initiatives' authors and commitee members should not have access to the admin panel. The problem is that with the change of the Terms of Service acceptance in the admin panel this is changing, so there's still some leftovers in the initiatives' permissions. As I only want to focus on ToS acceptance for now, I'll skip these specs and fix the real problem (cleaning the leftovers from #5736) on another PR to keep this small. * Fix typo * Fix for possible Cookie overflow with a long list of URL params Detected by code review * Remove unecessary namespaces * Fix spec * Bring consistency to the spec messages * "has not accepted" sounds better than "did not accepted" * sometimes I was using "has a message" and other times "shows a message" * sometimes we were using ToS and other times TOS * Add missing specs for Templates' specs * Remove unecessary return Apply suggestions from code review Co-authored-by: Antti Hukkanen <[email protected]> * Fix the stored request.path to not mess with the frontend's stored location Apply suggestions from code review Co-authored-by: Antti Hukkanen <[email protected]> * Fetch from stored_location_for so the session value is cleaned Apply suggestions from code review Co-authored-by: Antti Hukkanen <[email protected]> * Fix traits usages in factories calls Apply suggestions from code review Co-authored-by: Antti Hukkanen <[email protected]> * Introduce "needs admin TOS accepted" shared example * Fix rubocop offenses * Fix rubocop offenses * Make the user configurable for "needs admin TOS accepted" shared example * Fix rubocop offense * Refactor spec to shared examples * Add example for roles that aren't admin --------- Co-authored-by: Alexandru Emil Lupu <[email protected]> Co-authored-by: Antti Hukkanen <[email protected]>
alecslupu
force-pushed
the
backport/0.27/dont-allow-access-to-admin-pan-10117
branch
from
97edc4c to
2aaffd3
Compare
andreslucena
approved these changes
Jun 16, 2023
andreslucena
deleted the
backport/0.27/dont-allow-access-to-admin-pan-10117
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #10117 to v0.27