Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.27.4 and update tests #27

Merged
merged 17 commits into from
Aug 31, 2023
Merged

Bump to 0.27.4 and update tests #27

merged 17 commits into from
Aug 31, 2023

Conversation

paulinebessoles
Copy link
Contributor

@paulinebessoles paulinebessoles commented Aug 29, 2023

This PR aims to bump the module to 0.27.4 Decidim version, and update tests according to decidim/decidim#11042

It also fixes the issues with admin password updates

@paulinebessoles paulinebessoles marked this pull request as ready for review August 29, 2023 12:48
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16% ⚠️

Comparison is base (e4a9120) 67.76% compared to head (df5d321) 67.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   67.76%   67.60%   -0.16%     
==========================================
  Files          14       14              
  Lines         639      639              
==========================================
- Hits          433      432       -1     
- Misses        206      207       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulinebessoles paulinebessoles changed the title Update tests to match 0.27.4 Bump to 0.27.4 and update tests Aug 29, 2023
@armandfardeau
Copy link
Collaborator

Hello thanks for your contribution !

Could you please fix the failing CI workflow?

@paulinebessoles paulinebessoles marked this pull request as draft August 29, 2023 13:33
@armandfardeau armandfardeau requested review from a team, luciegrau, armandfardeau and Quentinchampenois and removed request for a team, luciegrau and armandfardeau August 30, 2023 14:36
@armandfardeau armandfardeau marked this pull request as ready for review August 30, 2023 14:39
Copy link
Contributor Author

@paulinebessoles paulinebessoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Copy link
Contributor

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the current module's version.

Also we could add the release generator and push to rubygems job in CD

lib/decidim/friendly_signup/version.rb Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@paulinebessoles paulinebessoles merged commit 9b8ece1 into main Aug 31, 2023
@paulinebessoles paulinebessoles deleted the fix/tests_admin_tos branch August 31, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants