-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup crypto utils #838
cleanup crypto utils #838
Conversation
* cleanup crypto utils * changeset * Update index.ts * finish: delete package.json utils export
🦋 Changeset detectedLatest commit: 918c97c The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-08-19T17:41:13Z |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
- Coverage 93.30% 93.27% -0.03%
==========================================
Files 115 115
Lines 32555 32447 -108
Branches 2560 2547 -13
==========================================
- Hits 30374 30266 -108
Misses 2143 2143
Partials 38 38
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question about the codecov change.
Any idea why the type docs aren't picking up for those CryptoUtils methods? I see there are comments above them.
- type: patch | ||
target: 90 | ||
informational: true | ||
if_ci_failed: success |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being done again? Can this be removed to a different PR that's in scope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same lines that are already in the config copy pasted to a different spot because the config was broken and not doing inheritance correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why the type docs aren't picking up for those CryptoUtils methods? I see there are comments above them.
Because the tbdocs thing is broken. It relies on typedoc internals that no longer function on newer typescript / typedoc versions. From what I can tell it was an incubation project that got adopted on a couple of repos and we should probably just tear it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but FYI that's unrelated to this PR. I'm just trying to standardize one way of importing crypto utils here
CryptoUtils
namespace (rather than 3 different ways)