cleanup crypto utils #830
Merged
cleanup crypto utils #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilovtim
requested review from
LiranCohen,
csuwildcat,
nitro-neal,
diehuxx and
thehenrytsai
as code owners
🦋 Changeset detectedLatest commit: c8fcc31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
csuwildcat
approved these changes
Aug 13, 2024
LiranCohen
approved these changes
Aug 13, 2024
thehenrytsai
approved these changes
Aug 13, 2024
shamilovtim
added a commit
that referenced
this pull request
Aug 13, 2024
This reverts commit fc234c3.
shamilovtim
added a commit
that referenced
this pull request
Aug 13, 2024
* add back examples * add back authServer.js * add back json-rpc changes * add back rpcserver * add back utils * add back agent exports * add back ws-rpc-server * add back auth-api * add back level.js * add back crypto randompin * add back test for randomPin * simplify request-uri * make testharness setup a little more readable * add pollWithTTL * add abort to pollWithTTL * add jsdoc to pollWithTTL * WIP * fix a couple of docs * param style nit * fix signing and migrate kms code to newer agent code * use the word "claims" rather than payload * format authServer and update code * push up latest WIP * remove dead code * bump types/node * cleanup * fix eslint * format test file * format with eslint * cleanup * format eslint config * Update authServer.js * Update tsconfig.json * check in wip * add correct wallet uri * comment * updates * cleanup * cleanup * add nearly finished latest wip * cleanup. add walletUri. * feedback * feedback * feedback * refactor out nonce * feedback * feedback: add better docs for walletUri * remove unnecessary clientUri * feedback * resolve merge conflict * feedback: client_id should contain the did * improve comment about walletconnectoptions * feedback: unabstract nonce creation * remove unused imports * feedback: slim down queryparams * merged lockfile * clarify comment about the grants * feedback: fail fast and let users catch errors * feedback * push up finalizations * bump crypto * examples * bump sinon * fix dependabot mess * try to fix builds * try to fix builds * use v9 lockfile * Revert "try to fix builds" This reverts commit d63c468. * Revert "try to fix builds" This reverts commit 3a58665. * Create flat-students-compare.md * fix ci * fix lockfile * Revert "fix lockfile" This reverts commit 775d15a. * fix lockfile * cleanup * fix ci * Delete authServer.js * test ci * fix build order * fix cve * fix eslint * bump lockfile * feedback * use dwn server default port * Update flat-students-compare.md * Update docs-ci.yml * Update flat-students-compare.md * stub globalthis fetch * Update tests-ci.yml * fix regex * cleanup * cleanup * add some patch tests * cleanup some changes * satisfy codecov patch * fix codecov bot * Update tests-ci.yml * latest * prettier fmt * Update wallet-connect.html * Update codecov.yml * add wallet connect example. change to portableDid data structure and delegateDid naming. * add connectedDid * cleanup example * cleanup * Update wallet-connect.html * add word wrap and viewport sizing * remove conditional returns in buildOidcUrl * timeout * feedback * Update oidc.ts * Update connect.ts * Update connect.ts * only one did for selection * feedback * Update packages/crypto/tests/utils.spec.ts Co-authored-by: Liran Cohen <[email protected]> * Update packages/crypto/tests/utils.spec.ts Co-authored-by: Liran Cohen <[email protected]> * fix flakes * Update connect.ts * Update connect.ts * run prettier and eslint * remove corepack * delegate did should use a did jwk * client should use a did jwk * better comments * Update oidc.ts * add comments * Update oidc.ts * cleanup comments * add some coverage * reorganize * Update web5.spec.ts * feedback: dont encrypt with the code challenge * feedback disable code challenge * clean out todo * Update connect.spec.ts * feedback didjwk * cleanup crypto utils (#830) * cleanup crypto utils * changeset * Update index.ts * finish: delete package.json utils export * add docs errors back * disable rule until typedoc is bumped * Revert "cleanup crypto utils (#830)" This reverts commit fc234c3. * renable typedoc * Update docs-ci.yml * update codeowners * Update CODEOWNERS --------- Co-authored-by: Liran Cohen <[email protected]>
shamilovtim
added a commit
that referenced
this pull request
Aug 13, 2024
* cleanup crypto utils * changeset * Update index.ts * finish: delete package.json utils export
shamilovtim
added a commit
that referenced
this pull request
Aug 20, 2024
* cleanup crypto utils (#830) * cleanup crypto utils * changeset * Update index.ts * finish: delete package.json utils export * bump dwn server * fix api bump * Update utils.ts * bump dwn server * maybe fix codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web5 crypto had a package.json named export which causes pain for different bundlers, mocha, etc. removed it and replaced with a regular esm export.
merge after #713