Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add identifier to pkarr error for debugging purposes #508

Merged
merged 2 commits into from
May 2, 2024

Conversation

LiranCohen
Copy link
Member

We sometimes get failures in CI publishing to the DHT. In order to make debugging these errors easier, we add the identifier to the error thrown.

Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 26d2f01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web5/dids Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LiranCohen LiranCohen requested a review from csuwildcat as a code owner May 2, 2024 17:12
Copy link
Contributor

github-actions bot commented May 2, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-05-02T17:14:57Z 26d2f01

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (3abb717) to head (26d2f01).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   90.81%   90.81%           
=======================================
  Files         116      116           
  Lines       29430    29430           
  Branches     2156     2156           
=======================================
  Hits        26727    26727           
  Misses       2668     2668           
  Partials       35       35           
Components Coverage Δ
agent 79.90% <ø> (ø)
api 97.91% <ø> (ø)
common 98.68% <ø> (ø)
credentials 95.26% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.66% <100.00%> (ø)
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

@LiranCohen LiranCohen merged commit d3814cd into main May 2, 2024
11 checks passed
@LiranCohen LiranCohen deleted the lirancohen/add-identifier-to-pkarr-error branch May 2, 2024 18:18
@github-actions github-actions bot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants