Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add identifier to pkarr error for debugging purposes #508

Merged
merged 2 commits into from
May 2, 2024
Merged

add identifier to pkarr error for debugging purposes #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d95e98b
add identifier to pkarr error for debugging purposes
LiranCohen May 2, 2024
26d2f01
add changeset
LiranCohen May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tall-mugs-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@web5/dids": patch
---

We sometimes get failures in CI publishing to the DHT. In order to make debugging these errors easier, we add the identifier to the error thrown.
2 changes: 1 addition & 1 deletion packages/dids/src/methods/did-dht.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ export class DidDhtDocument {
});

} catch (error: any) {
throw new DidError(DidErrorCode.InternalError, `Failed to put Pkarr record: ${error.message}`);
throw new DidError(DidErrorCode.InternalError, `Failed to put Pkarr record for identifier ${identifier}: ${error.message}`);
}

// Return `true` if the DHT request was successful, otherwise return `false`.
Expand Down
Loading