-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Web5 agent and API packages to latest crypto and dids versions #445
Conversation
15069b7
to
f4d5b0f
Compare
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-03-29T18:58:58Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 93.37% 90.53% -2.85%
==========================================
Files 80 112 +32
Lines 23955 29028 +5073
Branches 1924 2076 +152
==========================================
+ Hits 22369 26281 +3912
- Misses 1541 2712 +1171
+ Partials 45 35 -10
|
876d32c
to
90b6048
Compare
90b6048
to
5cc787a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to leave a comment and request changes in the previous review.
I looked over the files I'm more familiar with and found some small comments/copy-pasta, but otherwise everything looks great!
Also the version of the dev-env
container. Other than that mostly relying on tests!
But this is a great effort!!
tenant?: string; | ||
} | ||
|
||
export interface DidMethodCreateOptions<TKeyManager> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this default to a KeyManager like all of the other interfaces do?
*/ | ||
private _agent?: Web5PlatformAgent; | ||
|
||
private _didMethods: Map<string, DidMethodApi> = new Map(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to figure out how to use this. If two methods are declared here what does it do? Maybe a comment for all of the params would help understand what to do with all of them
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
f842ffd
to
2395ad4
Compare
Signed-off-by: Frank Hinek <[email protected]>
Summary
This PR will:
@web5/agent
,@web5/user-agent
,@web5/proxy-agent
,@web5/identity-agent
, and@web5/api
to use the latest releases of@web5/common
,@web5/crypto
, and@web5/dids
.@tbd54566975/dwn-sdk-js
dependency tov0.2.18
in theagent
package.@tbd54566975/dwn-sdk-js
as a dependency from theapi
package so that the DWN SDK versions can no longer diverge. All DWN related functionality now comes fromagent
package.agent
,user-agent
,proxy-agent
andidentity-agent
tov0.3.0
api
tov0.9.0
dwn-server
dev dependency version tov0.1.11
Fixes #317
Fixes #440