-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add did resolver in memory cache when none is declared #305
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Depends on #306 to fix the weird typescript flakes |
TBDocs Report ✅ No errors or warnings @web5/api
TBDocs Report Updated at 2023-12-01T20:07:46Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
+ Coverage 91.77% 91.80% +0.02%
==========================================
Files 73 73
Lines 15765 15805 +40
Branches 1448 1456 +8
==========================================
+ Hits 14469 14510 +41
+ Misses 1270 1269 -1
Partials 26 26
|
Addressed in #445 |
Currently the Did Resolver Cache defaults to NOOP when none is supplied. This has implications for performance. Instead, provide a basic unpersisted in memory cache for the duration of the web5-js session.