Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor creation and signing of verifiable presentation for web5-js #351

Closed
nitro-neal opened this issue Dec 13, 2023 · 4 comments
Closed
Assignees
Labels
credentials SSI functionality

Comments

@nitro-neal
Copy link
Contributor

Since signing has changed and we use the did's key manager instead of signOptions it is now time to bring back VerifiablePresentation

Will be similar in scope to the changes that happend recently here #302 but for VPs

@nitro-neal nitro-neal added the credentials SSI functionality label Dec 13, 2023
@nitro-neal nitro-neal self-assigned this Dec 13, 2023
@frankhinek frankhinek moved this to Todo in SDK Development Dec 13, 2023
@nitro-neal
Copy link
Contributor Author

We need Verifiable Presentations to wrap our presentationSubmission. An example can be found here: https://identity.foundation/presentation-exchange/#presentation-submissions

Currently we have this (only presentationResult object, no VerifiablePresentation)

const presentationResult = PresentationExchange.createPresentationFromCredentials({ vcJwts: signedVcJwts, presentationDefinition: presentationDefinition })

I suggest we change it to be like this:

const vp: VerifiablePresentation = PresentationExchange.createPresentationFromCredentials({ vcJwts: signedVcJwts, presentationDefinition: presentationDefinition })
const vpJwt = await vp.sign({did:myDid})

The change to our existing codebase will be to:

  • Create a VerifiablePresentation model object
  • Update the createPresentationFromCredentials to construct a vp that has a presentationSubmission from the inputs it is given

@nitro-neal
Copy link
Contributor Author

nitro-neal commented Jan 8, 2024

closing for duplicate: decentralized-identity/web5-kt#175

@angiejones
Copy link
Contributor

closing for duplicate: TBD54566975/web5-kt#175

this ticket is for JS right? the "dup" is for KT

@nitro-neal nitro-neal reopened this Jan 9, 2024
@nitro-neal nitro-neal changed the title Refactor creation and signing of verifiable presentation Refactor creation and signing of verifiable presentation for web5-js Jan 9, 2024
@nitro-neal nitro-neal moved this from Done to In Progress in SDK Development Jan 10, 2024
@nitro-neal nitro-neal removed the status in SDK Development Jan 10, 2024
@nitro-neal nitro-neal moved this to In Progress in SDK Development Jan 17, 2024
@nitro-neal
Copy link
Contributor Author

in pr #382

@nitro-neal nitro-neal moved this from In Progress to In Code Review in SDK Development Jan 24, 2024
@nitro-neal nitro-neal moved this from In Code Review to Done in SDK Development Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
credentials SSI functionality
Projects
None yet
Development

No branches or pull requests

2 participants