Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Verifiable Presentation and Verifiable Presentation Signing #175

Closed
nitro-neal opened this issue Dec 19, 2023 · 3 comments
Closed
Assignees
Labels
credentials-pkg credentials package pd-v2 Presentation Definition V2

Comments

@nitro-neal
Copy link
Contributor

We need Verifiable Presentations to wrap our presentationSubmission. An example can be found here: https://identity.foundation/presentation-exchange/#presentation-submissions

Currently we have this (only presentationSubmission object, no VerifiablePresentation)

val presentationSubmission: PresentationSubmission = PresentationExchange.createPresentationFromCredentials(listOf(vcJwt2, vcJwt1), pd)

I suggest we change it to be like this:

val vp: VerifiablePresentation = PresentationExchange.createPresentationFromCredentials(listOf(vcJwt2, vcJwt1), pd)
val vpJwt = vp.sign(issuerDid)

The change to our existing codebase will be to:

  • Create a VerifiablePresentation model object and
  • update the createPresentationFromCredentials to construct a vp that has a presentationSubmission from the inputs it is given
@nitro-neal nitro-neal added the pd-v2 Presentation Definition V2 label Dec 19, 2023
@nitro-neal nitro-neal self-assigned this Dec 19, 2023
@nitro-neal nitro-neal added the credentials-pkg credentials package label Dec 19, 2023
@andresuribe87
Copy link
Contributor

This makes sense to me!

@andresuribe87
Copy link
Contributor

Just FYI, a related convo will happen in #176. Shouldn't be a blocker for this though.

@nitro-neal
Copy link
Contributor Author

#184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
credentials-pkg credentials package pd-v2 Presentation Definition V2
Projects
None yet
Development

No branches or pull requests

2 participants