You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
signing a verifiable credential is a bit rough around the edges at the moment - example here. Specifically,
alg is hardcoded to EdDSA. This makes passing in a signer function as an argument unnecessary because there's only one possible DSA that can be used: Ed25519.
subjectDid is required when calling sign, but also required when calling create. I think we can remove it as a required argument for sign
@frankhinek how do you imagine sign's method signature will change given the changes proposed in #271?
The text was updated successfully, but these errors were encountered:
Thanks for the feedback @mistermoe ! Great to have someone building to reveal how the SDK can be improved.
Agreed on the header and JWT payload details ought to be customizable.
Yes, once we can agree on our approach to a consistent set of Key Generators, Signers, etc. that will require making changes across the DID and VC public API.
signing a verifiable credential is a bit rough around the edges at the moment - example here. Specifically,
alg
is hardcoded toEdDSA
. This makes passing in asigner
function as an argument unnecessary because there's only one possible DSA that can be used:Ed25519
.subjectDid
is required when callingsign
, but also required when callingcreate
. I think we can remove it as a required argument forsign
@frankhinek how do you imagine
sign
's method signature will change given the changes proposed in #271?The text was updated successfully, but these errors were encountered: