Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor signing verifiable credentials #302

Closed
mistermoe opened this issue Nov 20, 2023 · 2 comments
Closed

Refactor signing verifiable credentials #302

mistermoe opened this issue Nov 20, 2023 · 2 comments
Assignees
Labels
credentials SSI functionality

Comments

@mistermoe
Copy link
Contributor

mistermoe commented Nov 20, 2023

signing a verifiable credential is a bit rough around the edges at the moment - example here. Specifically,

  • alg is hardcoded to EdDSA. This makes passing in a signer function as an argument unnecessary because there's only one possible DSA that can be used: Ed25519.
  • subjectDid is required when calling sign, but also required when calling create. I think we can remove it as a required argument for sign

@frankhinek how do you imagine sign's method signature will change given the changes proposed in #271?

@frankhinek
Copy link
Contributor

Thanks for the feedback @mistermoe ! Great to have someone building to reveal how the SDK can be improved.

  • Agreed on the header and JWT payload details ought to be customizable.
  • Yes, once we can agree on our approach to a consistent set of Key Generators, Signers, etc. that will require making changes across the DID and VC public API.

@mistermoe
Copy link
Contributor Author

First pass of this is done. sign was refactored to take just a DID. will open other more focused issues as they crop up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
credentials SSI functionality
Projects
None yet
Development

No branches or pull requests

3 participants