-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(key-manager): add method to compute a shared secret #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #555 +/- ##
==========================================
+ Coverage 67.58% 77.39% +9.80%
==========================================
Files 62 71 +9
Lines 1530 1893 +363
Branches 247 321 +74
==========================================
+ Hits 1034 1465 +431
- Misses 400 426 +26
+ Partials 96 2 -94 |
mirceanis
force-pushed
the
541-add-key-manager-ecdh-wrapper
branch
from
June 9, 2021 12:06
e4080b4
to
6d49bca
Compare
mirceanis
force-pushed
the
541-add-key-manager-ecdh-wrapper
branch
from
June 10, 2021 09:59
6d49bca
to
34d93ce
Compare
awoie
suggested changes
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - just fixed some comments
Co-authored-by: Oliver Terbu <[email protected]>
awoie
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's here
key-manager
plugin exposes a new method that computes a shared key (Diffie Hellman) between a secret key the agent manages and a public key of another party, returning a promise that resolves to the hex encoding string of the shared key.The result is the RAW shared secret (scalar multiplication in the case of ECC).
To use this for symmetric encryption, one would need to hash it to arrive at a shared Symmetric Key
AbstractKeyManagementSystem
class for a new abstract methodsharedKey()
kms-local
package implements this newsharedKey
methodkms-local
supportsEd25519
&X25519
keys for computing the shared key. Keys are converted toX25519
if they areEd25519
closes #541