Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proposal] JWE functionality should be implemented on the key-manager layer #556

Closed
mirceanis opened this issue Jun 10, 2021 · 0 comments · Fixed by #557
Closed

[proposal] JWE functionality should be implemented on the key-manager layer #556

mirceanis opened this issue Jun 10, 2021 · 0 comments · Fixed by #557
Assignees
@mirceanis
Labels
enhancement New feature or request planned-feature don't close this just for being stale

Comments

@mirceanis
Copy link
Member

The AbstractKeyManagementSystem class is expected to perform some JWE encryption and decryption but it does not have all the prerequisites to deal with all JWE types (it may knowledge of key IDs as they appear in DID documents).

Since the key-manager already implements a shared secret method (see #541 and #555) it should be enough to do all the JWE packing on this layer, thus simplifying the implementations of AbstractKeyManagementSystem
@mirceanis mirceanis added enhancement New feature or request planned-feature don't close this just for being stale labels Jun 10, 2021
@mirceanis mirceanis self-assigned this Jun 10, 2021
mirceanis added a commit that referenced this issue Jun 10, 2021
@mirceanis
feat(key-manager): implement JWE functionality directly in key-manager
2bfe223 
The KMS is only used to compute shared secret, it doesn't need to deal with JWE directly
fixes #556
mirceanis added a commit that referenced this issue Jun 10, 2021
@mirceanis
feat(key-manager): implement JWE functionality directly in key-manager
2d7e858 
The KMS is only used to compute shared secret, it doesn't need to deal with JWE directly
fixes #556
@mirceanis mirceanis mentioned this issue Jun 10, 2021
Merged
mirceanis added a commit that referenced this issue Jun 11, 2021
@mirceanis
feat(key-manager): implement JWE functionality directly in `key-manag…
a030f0a 
…er` (#557)

The KMS is only used to compute shared secret, it doesn't need to deal with JWE directly.
This is now the responsibility of `@veramo/key-manager`
fixes #556
@mirceanis mirceanis mentioned this issue Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirceanis mirceanis

Labels
enhancement New feature or request planned-feature don't close this just for being stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(key-manager): implement JWE functionality directly in key-manager decentralized-identity/veramo
1 participant
@mirceanis