Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all new Error(...) with new DwnError(...) #387

Closed
thehenrytsai opened this issue May 31, 2023 · 8 comments
Closed

Replace all new Error(...) with new DwnError(...) #387

thehenrytsai opened this issue May 31, 2023 · 8 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest For the hacking month of October refactoring Code refactoring with no functional impact

Comments

@thehenrytsai
Copy link
Contributor

thehenrytsai commented May 31, 2023

Background:

currently we have new DwnError(...) and new Error(...) throughout the code

Objective:

  • Replace all new Error(...) with new DwnError(...)
  • List of DwnError codes can be found here: src/core/dwn-error.ts

Picking Up This Issue:

  • If you'd like to work on this, please comment "picking this up" below, and I'll assign the issue to you

Questions:

Resources:

  • Creating a Pull Request: If you're new to GitHub and unsure how to create a pull request, follow this step-by-step guide.

Remember, communication is key! If you have any questions or face any challenges, we're here to help so please don't hesitate to reach out.

Good Luck! 🍁

@thehenrytsai thehenrytsai added good first issue Good for newcomers refactoring Code refactoring with no functional impact labels May 31, 2023
@EbonyLouis EbonyLouis added the hacktoberfest For the hacking month of October label Sep 26, 2023
@tux7P
Copy link

tux7P commented Sep 27, 2023

picking this up 🙂

@EbonyLouis
Copy link
Contributor

@tux7P Yay! I'll assign it to you now.

I'd also like to note that Hacktoberfest officially kicks off on October 1st. Contributions made before the event may not be eligible for the challenge. However, feel free to start working on it, but I'd recommend holding off on submitting your PR until the event begins.

to be eligible for Hacktoberfest's official prizes make sure you're registered, registration is now open. Reach out if you need any help 🥳

@suvekshyabhandari356
Copy link

Hi @EbonyLouis @thehenrytsai
If this is not being worked on, I would like to work on it.

@EbonyLouis
Copy link
Contributor

@tux7P Hey do you still want to work on this issue?

@EbonyLouis
Copy link
Contributor

@FroostyCodes it's all yours, assigning it to you now, thanks! 🥳

@Tushar98644
Copy link

@EbonyLouis can i work on this if the current assignee is inactive ? Thanks

@flothjl
Copy link
Contributor

flothjl commented Oct 27, 2023

@Tushar98644 are you still wanting to work on this? if not, I can pick it up.
@EbonyLouis

@suvekshyabhandari356 suvekshyabhandari356 removed their assignment Oct 28, 2023
@EbonyLouis
Copy link
Contributor

@flothjl thanks, you can work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest For the hacking month of October refactoring Code refactoring with no functional impact
Projects
None yet
Development

No branches or pull requests

6 participants