Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support protocol authorized RecordsDelete #576

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Conversation

diehuxx
Copy link

@diehuxx diehuxx commented Oct 25, 2023

Addresses #557. Support protocol authorized deletes for both actors (author, recipient, anyone) and roles ($globalRole, $contextRole).

@codesandbox
Copy link

codesandbox bot commented Oct 25, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #576 (7e5a524) into main (52523db) will increase coverage by 0.05%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 7e5a524 differs from pull request most recent head d2e76e0. Consider uploading reports for the commit d2e76e0 to get more accurate results

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   97.68%   97.73%   +0.05%     
==========================================
  Files          66       66              
  Lines        7932     8049     +117     
  Branches     1150     1163      +13     
==========================================
+ Hits         7748     7867     +119     
+ Misses        178      176       -2     
  Partials        6        6              
Files Coverage Δ
src/core/dwn-error.ts 100.00% <100.00%> (ø)
src/core/protocol-authorization.ts 99.40% <100.00%> (+0.37%) ⬆️
src/handlers/records-delete.ts 100.00% <100.00%> (ø)
src/interfaces/records-delete.ts 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

@diehuxx diehuxx force-pushed the diehuxx/protocol-delete branch from 7e5a524 to d2e76e0 Compare October 30, 2023 21:32
@diehuxx diehuxx merged commit 66ec588 into main Oct 31, 2023
4 checks passed
@thehenrytsai thehenrytsai deleted the diehuxx/protocol-delete branch April 8, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants