feat: handle absolute paths #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
approved these changes
Nov 6, 2020
zregvart
force-pushed
the
pr/consider-absolute-relative-to-dir
branch
from
e5be794
to
ac64139
Compare
|
Thanks for the suggestion @jyn514, I've incorporated it and added one line to the changelog. |
jyn514
reviewed
Nov 6, 2020
Some `href` values might start with a `/`, denoting an absolute path and
should be considered relative to the given `dir` path. In `url::Url`
`join`-ing absolute path results in that absolute path, i.e.:
```
assert!(base.join(Url::from_file_path("/page.html").unwrap()) == "/page.html")
```
In this case deadlinks would flag `/page.html` to be broken, whereas it
could be considered valid relative to the `base` path.
Co-authored-by: Joshua Nelson <[email protected]>
zregvart
force-pushed
the
pr/consider-absolute-relative-to-dir
branch
from
ac64139
to
0bfc5fe
Compare
|
Fixed the changelog and rebased. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
hrefvalues might start with a/, denoting an absolute path andshould be considered relative to the given
dirpath. Inurl::Urljoin-ing absolute path results in that absolute path, i.e.:In this case deadlinks would flag
/page.htmlto be broken, whereas itcould be considered valid relative to the
basepath.