fix: correctly treat absolute paths against dir
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zregvart
force-pushed
the
pr/fix-absolute-paths-in-subdir
branch
2 times, most recently
from
db7444a
to
5793148
Compare
jyn514
reviewed
Nov 8, 2020
Absolute paths should be rooted from the `--dir` path, not against the base directory of the examined file. For example, given file in `$DIR/sub/a.html` with a link to `/other/b.html` and deadlinks invoked with `--dir $DIR`, that link should be evaluated as `$DIR/other/b.html`, not as `$DIR/sub/other/b.html`.
zregvart
force-pushed
the
pr/fix-absolute-paths-in-subdir
branch
from
5793148
to
622a1d5
Compare
jyn514
approved these changes
Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm afraid a bug was introduced in #91: Absolute paths should be rooted from the
--dirpath, not against the base directory of the examined file. For example, given file in$DIR/sub/a.htmlwith a link to/other/b.htmland deadlinks invoked with--dir $DIR, that link should be evaluated as$DIR/other/b.html, not as$DIR/sub/other/b.html.