Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement restrictions on default column searching for #268 #274

Merged
merged 10 commits into from
Jan 18, 2025

Conversation

ddworken
Copy link
Owner

Fixes #268

@ddworken
Copy link
Owner Author

cc: @chelmertz

Copy link

@chelmertz chelmertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch seems to work for my use case at least 👍 🙏

@ddworken
Copy link
Owner Author

@chelmertz FYI, I updated this to instead having a config option for which columns are included in default searches. This should offer the same capabilities as the original approach while being more extensible. LMK if you have any issues with this!

@ddworken ddworken merged commit 65d1ebf into master Jan 18, 2025
20 checks passed
@chelmertz
Copy link

This works super well for me! Previously I was also having trouble targeting code ~/code/github/..., and I thought it was a separate issue with either the space after code, or that ~ was interpreted weirdly by sqlite; but those problems went away with this patch too (release 0.326).

Thanks a lot <3

@ddworken
Copy link
Owner Author

Awesome, thank you! And if you do run into any more issues or come up with any more feature requests, please let me know. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: remove or configure opt-out for including CWD/hostname from query
2 participants