-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement restrictions on default column searching for #268 #274
Conversation
cc: @chelmertz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch seems to work for my use case at least 👍 🙏
…s, to prep for future changes where we may add support for other default columns
…and caused DB query correctness issues
@chelmertz FYI, I updated this to instead having a config option for which columns are included in default searches. This should offer the same capabilities as the original approach while being more extensible. LMK if you have any issues with this! |
This works super well for me! Previously I was also having trouble targeting Thanks a lot <3 |
Awesome, thank you! And if you do run into any more issues or come up with any more feature requests, please let me know. :) |
Fixes #268