Request: remove or configure opt-out for including CWD/hostname from query

[chelmertz]

Hello, thanks for a neat program!

I am frequently launching vscode in a terminal, with variants of: code ~/code/my/project

Searching for that history entry, competes with all other entries made with "code/my/project" and I never get that suggestion, when I search for "code". To work around this, I played around with:

chelmertz@2e7e027

Bonus question: I tried running tests after changing this in my "fork", but the tests worked with the actual ~/.zsh_history et al. files, so I quickly abandoned that. It would be nicer to have a developer guide for installing things without going through the python script -> releases -> figure out what each release contains, just when trying out a small change; but I can imagine the current flow suits your flow of development :)

[roland-5]

Removing this feature would kill the point of using hishtory for me. I have several machines, but they do different things and without CWD and hostname I would have a problem comparing results and data.

[chelmertz]

@roland-5 could you explain more? I'm neither suggesting "don't show CWD/hostname in search window" (there's config for that) nor "don't store CWD/hostname with history data".

I'm suggesting "don't match on CWD/hostname by default, without any way of opt-ing out". There is already a way to opt-in for the behavior, quoting hishtory help query:

Example queries:
'hishtory query apt-get'  		# Find shell commands containing 'apt-get'
'hishtory query apt-get install'  	# Find shell commands containing 'apt-get' and 'install'
'hishtory query curl cwd:/tmp/'  	# Find shell commands containing 'curl' run in '/tmp/'
'hishtory query curl user:david'	# Find shell commands containing 'curl' run by 'david'
'hishtory query curl host:x1'		# Find shell commands containing 'curl' run on 'x1'
'hishtory query exit_code:1'		# Find shell commands that exited with status code 1
'hishtory query before:2022-02-01'	# Find shell commands run before 2022-02-01

See the line with cwd:/tmp/.

---

Are you aware of any way for me to resolve my use case?

[ddworken]

Thank you for all the detailed thoughts and feedback @chelmertz! Your use case makes sense to me, though I'll say I do often find myself searching based on the cwd such that I do like having it included in the query by default. But making this configurable makes perfect sense to me. I can work on a PR for this and will tag you on it.

Though if you are motivated to make the change yourself in the meantime (2e7e027 seems like it is on the right track for that), check out the contributing docs for info on how to run tests.