-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dbt-semantic-interfaces to 0.5.1 #1104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This was referenced Mar 26, 2024
Merged
In order to proceed with development on using Metric inputs in filter expressions, we need to update our dbt-semantic-interfaces dependency to 0.5.1 or later. This change carries some added complexity along with it, since our dev dependencies specify dbt-core and dbt-<adapter> package dependencies bound to dbt-core 1.7 version range. This creates an unresolvable dependency version conflict, since dbt-core depends on dbt-semantic-interfaces 0.4.x. For the time being we can get away with relying on the pre-installed dbt core + adapter packages pulled in by dbt-metricflow, and simply allow metricflow's specification for dbt-semantic-interfaces to override the installed package. Most of the changes in this commit are a result of needing to manage the dbt-semantic-interfaces version discrepancies by relying solely on the dbt-metricflow pre-install for dbt core + adapter dependencies. The one additional tweak is the MetricFlow minor version, which was improperly set to the currently available release of 0.205.0. Since this is the top of a set of serious breaking changes we need to ensure we release as a full minor, so the next version will be 0.206.0.
tlento
force-pushed
the
update-dsi-0.5.1
branch
from
March 26, 2024 22:00
294de35
to
adf011f
Compare
tlento
added
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Mar 26, 2024
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
March 26, 2024 22:01
— with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
March 26, 2024 22:01
— with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
March 26, 2024 22:01
— with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
March 26, 2024 22:01
— with
GitHub Actions
Inactive
courtneyholcomb
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Mar 26, 2024
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
March 26, 2024 22:10
— with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
March 26, 2024 22:10
— with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
March 26, 2024 22:10
— with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
March 26, 2024 22:10
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to proceed with development on using Metric inputs in
filter expressions, we need to update our dbt-semantic-interfaces
dependency to 0.5.1 or later.
This change carries some added complexity along with it, since our
dev dependencies specify dbt-core and dbt- package
dependencies bound to dbt-core 1.7 version range. This creates
an unresolvable dependency version conflict, since dbt-core depends
on dbt-semantic-interfaces 0.4.x.
For the time being we can get away with relying on the pre-installed
dbt core + adapter packages pulled in by dbt-metricflow, and
simply allow metricflow's specification for dbt-semantic-interfaces
to override the installed package.
Most of the changes in this commit are a result of needing to manage
the dbt-semantic-interfaces version discrepancies by relying solely
on the dbt-metricflow pre-install for dbt core + adapter dependencies.
The one additional tweak is the MetricFlow minor version, which was
improperly set to the currently available release of 0.205.0. Since
this is the top of a set of serious breaking changes we need to ensure
we release as a full minor, so the next version will be 0.206.0.