Streamline MetricFlow build contents #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2024
Merged
tlento
changed the title
courtneyholcomb
approved these changes
Mar 21, 2024
The validation duration file was a temporary benchmarking action that is so old it still references poetry commands, which have not worked inside the MetricFlow repo for nearly a year now. This was uncovered in a rename operation associated with forking the test package out to repo root, so we just tidy it up here.
The MetricFlow build was taking up 1.5-3 MB on disk, a large part of which was the test package. Confusingly, the MetricFlow build also included the contents of dbt-metricflow, which is meant to be a separate distribution wrapper for MetricFlow itself, so that's odd. This commit cleans up the exclude list to be more appropriate to MetricFlow's repository structure, and finishes the job of reducing the size of the MetricFlow distribution packages by a factor of 4. Most of the work was handled incidentally by moving the tests under the repository root tests directory, which happened to be in the exclude list already.
tlento
force-pushed
the
clean-up-package-distribution
branch
from
bb38847
to
7ff6846
Compare
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MetricFlow build was taking up 1.5-3 MB on disk, a large
part of which was the test package. Confusingly, the MetricFlow
build also included the contents of dbt-metricflow, which is
meant to be a separate distribution wrapper for MetricFlow itself,
so that's odd.
This commit cleans up the exclude list to be more appropriate to
MetricFlow's repository structure, and finishes the job of reducing
the size of the MetricFlow distribution packages by a factor of 4.
Most of the work was handled incidentally by moving the tests under
the repository root tests directory, which happened to be in the
exclude list already.