Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbt-semantic-interfaces to 0.5.1 #1104

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Update dbt-semantic-interfaces to 0.5.1 #1104

merged 1 commit into from
Mar 27, 2024

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Mar 26, 2024

In order to proceed with development on using Metric inputs in
filter expressions, we need to update our dbt-semantic-interfaces
dependency to 0.5.1 or later.

This change carries some added complexity along with it, since our
dev dependencies specify dbt-core and dbt- package
dependencies bound to dbt-core 1.7 version range. This creates
an unresolvable dependency version conflict, since dbt-core depends
on dbt-semantic-interfaces 0.4.x.

For the time being we can get away with relying on the pre-installed
dbt core + adapter packages pulled in by dbt-metricflow, and
simply allow metricflow's specification for dbt-semantic-interfaces
to override the installed package.

Most of the changes in this commit are a result of needing to manage
the dbt-semantic-interfaces version discrepancies by relying solely
on the dbt-metricflow pre-install for dbt core + adapter dependencies.

The one additional tweak is the MetricFlow minor version, which was
improperly set to the currently available release of 0.205.0. Since
this is the top of a set of serious breaking changes we need to ensure
we release as a full minor, so the next version will be 0.206.0.

@cla-bot cla-bot bot added the cla:yes label Mar 26, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

In order to proceed with development on using Metric inputs in
filter expressions, we need to update our dbt-semantic-interfaces
dependency to 0.5.1 or later.

This change carries some added complexity along with it, since our
dev dependencies specify dbt-core and dbt-<adapter> package
dependencies bound to dbt-core 1.7 version range. This creates
an unresolvable dependency version conflict, since dbt-core depends
on dbt-semantic-interfaces 0.4.x.

For the time being we can get away with relying on the pre-installed
dbt core + adapter packages pulled in by dbt-metricflow, and
simply allow metricflow's specification for dbt-semantic-interfaces
to override the installed package.

Most of the changes in this commit are a result of needing to manage
the dbt-semantic-interfaces version discrepancies by relying solely
on the dbt-metricflow pre-install for dbt core + adapter dependencies.

The one additional tweak is the MetricFlow minor version, which was
improperly set to the currently available release of 0.205.0. Since
this is the top of a set of serious breaking changes we need to ensure
we release as a full minor, so the next version will be 0.206.0.
@tlento tlento added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Mar 26, 2024
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS March 26, 2024 22:01 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS March 26, 2024 22:01 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS March 26, 2024 22:01 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS March 26, 2024 22:01 — with GitHub Actions Inactive
@tlento tlento marked this pull request as ready for review March 26, 2024 22:02
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Mar 26, 2024
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS March 26, 2024 22:10 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS March 26, 2024 22:10 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS March 26, 2024 22:10 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS March 26, 2024 22:10 — with GitHub Actions Inactive
Base automatically changed from move-cli-to-dbt-metricflow to main March 26, 2024 22:15
@tlento tlento merged commit 48844ee into main Mar 27, 2024
33 checks passed
@tlento tlento deleted the update-dsi-0.5.1 branch March 27, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants