Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic model configs #4231

Merged
merged 9 commits into from
Oct 11, 2023
Merged

Semantic model configs #4231

merged 9 commits into from
Oct 11, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Addresses issue #4180

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner October 9, 2023 20:33
@vercel
Copy link

vercel bot commented Oct 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 11:18pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Oct 9, 2023
@matthewshaver matthewshaver linked an issue Oct 9, 2023 that may be closed by this pull request
Supported configs (meta, enabled, group) for semantic models #4180
Closed
runleonarun
runleonarun reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @matthewshaver IS there any way to version the semantic models tabs here? The floating versioned text is a little confusing.

website/docs/reference/resource-configs/enabled.md Show resolved Hide resolved
website/docs/reference/resource-configs/enabled.md Show resolved Hide resolved
website/docs/reference/resource-configs/meta.md Show resolved Hide resolved
runleonarun
runleonarun reviewed Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about the nested config key in examples

website/docs/reference/resource-configs/enabled.md Show resolved Hide resolved
runleonarun
runleonarun approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny typo fix then 🚢 it!

website/docs/reference/resource-configs/enabled.md Outdated Show resolved Hide resolved
@matthewshaver matthewshaver merged commit ba6e2a8 into current Oct 11, 2023
7 checks passed
@matthewshaver matthewshaver deleted the issue-4180 branch October 11, 2023 23:18
This was referenced Nov 2, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supported configs (meta, enabled, group) for semantic models
3 participants
@matthewshaver @runleonarun @mirnawong1