Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enabled config for semantic models #4219

Merged
merged 5 commits into from
Nov 8, 2023
Merged

enabled config for semantic models #4219

merged 5 commits into from
Nov 8, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Oct 7, 2023 •
edited
Loading

related to: #3997
related to: #4281

What are you changing in this pull request and why?

  • Add an example for config in dbt_project.yml
  • Match the style for other resource types for models/semantic_models.yml
  • Simplify the definition by removing the explicit listing of applicable resource types
    • rather than bring it up-to-date by adding sources, metrics, and exposures

🎩

Previews

v1.7

image

Checklist

  • I have tested that the code examples work
  • I have tested that the changes look correct in the Vercel preview
  • Review the Content style guide and About versioning so my content adheres to these guidelines.

@vercel
Copy link

vercel bot commented Oct 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 9:10pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Oct 7, 2023
@matthewshaver
Copy link
Contributor

Closing as duplicate. Addressed in: #4231

@dbeatty10 dbeatty10 reopened this Nov 8, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review November 8, 2023 02:17
@dbeatty10 dbeatty10 requested a review from a team as a code owner November 8, 2023 02:17
@dbeatty10 dbeatty10 mentioned this pull request Nov 8, 2023
Closed
1 task
@matthewshaver matthewshaver merged commit 4e63205 into current Nov 8, 2023
7 checks passed
@matthewshaver matthewshaver deleted the dbeatty/semantic-models-enabled-config branch November 8, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @matthewshaver