Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All CLI flags should be passed after subcommand #4041

Closed
1 task done
Tracked by #8600
jtcohen6 opened this issue Sep 7, 2023 · 4 comments · Fixed by #4191
Closed
1 task done
Tracked by #8600

All CLI flags should be passed after subcommand #4041

jtcohen6 opened this issue Sep 7, 2023 · 4 comments · Fixed by #4191
Assignees
Labels
cloud-cli-beta content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@jtcohen6
Copy link
Collaborator

jtcohen6 commented Sep 7, 2023

Docs project

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/global-configs/command-line-flags

What part(s) of the page would you like to see updated?

For better consistency, all flags should be passed after the subcommand.

dbt run --no-populate-cache

This includes "global" flags (supported for all commands) that have historically been passed before the subcommand:

dbt --no-populate-cache run

We could continue supporting the latter for backward compatibility, but make clear that it is legacy/deprecated functionality and liable to be removed in the future. It is not supported to pass the same flag before "before" and "after."

This should be much easier for everyone, as it doesn't require remembering which flags are "global" or "not global," and which ones are supported in both places for legacy reasons.

Additional information

Blocked by:

@jtcohen6 jtcohen6 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear blocked_by_dev Awaiting merge of PR with associated functionality labels Sep 7, 2023
@mirnawong1 mirnawong1 self-assigned this Sep 7, 2023
@mirnawong1
Copy link
Contributor

@jtcohen6 , confirming this is no longer blocked by dev, right?

@jtcohen6 jtcohen6 removed the blocked_by_dev Awaiting merge of PR with associated functionality label Sep 28, 2023
@jtcohen6
Copy link
Collaborator Author

jtcohen6 commented Sep 28, 2023

@mirnawong1 Correct! Thanks for being on top of it :)

Most of this has been updated in main / for dbt Core v1.7. The only outstanding things here are:

This was referenced Oct 3, 2023
@mirnawong1
Copy link
Contributor

still monitoring this @jtcohen6 and @aranke - are the flagsp.warn_error, p.warn_error_options, and p.log_format still pending support?

so far this is how i've shaped the doc for this page:
Screenshot 2023-10-06 at 13 56 31

@mirnawong1
Copy link
Contributor

Hey @jtcohen6 @aranke ! Looks like the 3 flags are still being worked on so I'm going to leave them out until the docs team is informed otherwise 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud-cli-beta content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
2 participants