Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3159] [spike] Globalize remaining Click flags #8715

Closed
1 of 4 tasks
aranke opened this issue Sep 26, 2023 · 2 comments · Fixed by #9040
Closed
1 of 4 tasks

[CT-3159] [spike] Globalize remaining Click flags #8715

aranke opened this issue Sep 26, 2023 · 2 comments · Fixed by #9040
Assignees
Labels
bug Something isn't working High Severity bug with significant impact that should be resolved in a reasonable timeframe tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@aranke
Copy link
Member

aranke commented Sep 26, 2023

Housekeeping

  • I am a maintainer of dbt-core

Short description

Follow-up from #8670, globalize the following flags so that they can be passed in after the sub command and still work:

  • @p.warn_error
  • @p.warn_error_options
  • @p.log_format

Acceptance Criteria

The flags above are part of the following method

def global_flags(func):

Capture issues related to globalizing these flags

Impact to Other Teams

N/A

Will backports be required?

No

@github-actions github-actions bot changed the title Globalize remaining Click flags [CT-3159] Globalize remaining Click flags Sep 26, 2023
@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality backport 1.5.latest backport 1.6.latest labels Sep 26, 2023
@graciegoheen
Copy link
Contributor

Hey! Could you re-format this issue using the template, so we make sure we have all of the details?

@dbeatty10
Copy link
Contributor

This covers 3 out of the 4 UserConfig missing from global configs that showed up in a separate and independent audit.

What about indirect_selection? It is the only 1 of the 4 that showed up there but is not covered here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High Severity bug with significant impact that should be resolved in a reasonable timeframe tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants