Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #322
Description
Being able to search by column description has been requested multiple times (along with at least a dozen +1 upvotes):
Among other benefits, it was mentioned a couple times is that this would enable multi-language search at the column level.
Implementation details
The bulk of the new logic is in the
fuzzySearchObj
function withinsrc/app/services/project_service.js
. The code here looked a little long in the tooth, and I didn't make any attempts to improve it. Rather, I aimed for the minimal additions that would accomplish the goal. So now it's even longer in the tooth.It appeared that at one point, this code was meant to parse values purely based on their type (
string
,object
,array
, etc), but the original intent seems to have devolved a bit. Also,arguments
andlabel
no longer appear to be used.Down the road, a motivated individual could do some surgical refactoring of
fuzzySearchObj
without affecting anything else.Screenshot
🎩 Here's an example search result:
Clicking on the result and then the "Columns" tab gives:
Checklist
I have opened an issue to add/update docs,or docs changes are not required/relevant for this PRchangie new
to create a changelog entry