Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2017] Column descriptions are also included in the search #369

Closed
shinyatakimoto opened this issue Feb 2, 2023 · 1 comment
Closed
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@shinyatakimoto
Copy link

Describe the feature

Words in the column description text are also included in the search.

Who will this benefit?

Column names are defined in English due to database constraints. However, in countries where English is not the native language, many data users search for data in their native language, and it is often the case that column names defined in English do not match and are not displayed in search results.

Since there is no function to define the name of a column in another expression, we have created a document that includes the column name in the column description text. We hope that this modification will allow people to find appropriate data in the catalog by including the descriptive text of column names in the search results.

Example
column name: shop_name
shop name in Japanese: "店舗名"

@shinyatakimoto shinyatakimoto added enhancement New feature or request triage labels Feb 2, 2023
@github-actions github-actions bot changed the title Column descriptions are also included in the search [CT-2017] Column descriptions are also included in the search Feb 2, 2023
@dbeatty10
Copy link
Contributor

Thanks for reaching out @shinyatakimoto !

It looks like this has been requested multiple times:

Thanks for sharing the details of your use-case. Reading through the comments across these issues, it was mentioned a couple times is that this would enable multi-language search at the column level.

There's quite a few 👍 between your issue and the others, so I opened up a PR:

In the meantime, I'm going to close this particular issue as a duplicate of #322.

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
@dbeatty10 dbeatty10 added duplicate This issue or pull request already exists and removed triage labels Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants