Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid dbtRunner default callbacks being shared across instances #7279

Merged
merged 2 commits into from
Apr 11, 2023
Merged

fix: avoid dbtRunner default callbacks being shared across instances #7279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd863dd
fix: avoid dbtRunner default callbacks being shared across instances
chamini2 Apr 5, 2023
a03efdc
changie
chamini2 Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20230405-124315.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: avoid dbtRunner default callbacks being shared across instances
time: 2023-04-05T12:43:15.418016-04:00
custom:
Author: chamini2
Issue: "7278"
5 changes: 4 additions & 1 deletion core/dbt/cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,14 @@ def __init__(
project: Project = None,
profile: Profile = None,
manifest: Manifest = None,
callbacks: List[Callable[[EventMsg], None]] = [],
callbacks: List[Callable[[EventMsg], None]] = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah - reminds me of an all-time classic: https://florimond.dev/en/posts/2018/08/python-mutable-defaults-are-the-source-of-all-evil/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have all been caught by it at some point!

):
self.project = project
self.profile = profile
self.manifest = manifest

if callbacks is None:
callbacks = []
self.callbacks = callbacks

def invoke(self, args: List[str]) -> Tuple[Optional[List], bool]:
Expand Down