fix: avoid dbtRunner default callbacks being shared across instances #7279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamini2
changed the title
jtcohen6
reviewed
Apr 5, 2023
| @@ -40,11 +40,14 @@ def __init__( | |||
| project: Project = None, | |||
| profile: Profile = None, | |||
| manifest: Manifest = None, | |||
| callbacks: List[Callable[[EventMsg], None]] = [], | |||
| callbacks: List[Callable[[EventMsg], None]] = None, | |||
There was a problem hiding this comment.
ah - reminds me of an all-time classic: https://florimond.dev/en/posts/2018/08/python-mutable-defaults-are-the-source-of-all-evil/
There was a problem hiding this comment.
We have all been caught by it at some point!
QMalcolm
approved these changes
Apr 5, 2023
McKnight-42
approved these changes
Apr 6, 2023
|
Thanks @chamini2! I'm going to merge this, since it already has approval |
emmyoop
pushed a commit
that referenced
this pull request
Apr 11, 2023
…7279) * fix: avoid dbtRunner default callbacks being shared across instances * changie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7278
Description
default the callbacks argument of dbtRunner to None and create a new list as the default every time it runs.
Checklist
changie newto create a changelog entry