Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test hologram#51 (remove top pin for jsonschema) #7219

Closed
wants to merge 1 commit into from

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Mar 24, 2023

resolves #6775

Description

Run tests in CI with dbt-labs/hologram#51 (no jsonschema pin)

$ pip install --upgrade jsonschema -r dev-requirements.txt -r editable-requirements.txt
...
$ pip freeze | grep 'hologram'
hologram @ git+https://github.com/dbt-labs/hologram.git@e4f5741c544b58e028f35296b09b3c7cdd40c4a7
$ pip freeze | grep 'jsonschema'
jsonschema==4.17.3

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
  • I have run changie new to create a changelog entry - have added label for now, will do this if the PR passes CI

@jtcohen6 jtcohen6 added the Skip Changelog Skips GHA to check for changelog file label Mar 24, 2023
@cla-bot cla-bot bot added the cla:yes label Mar 24, 2023
@jtcohen6
Copy link
Contributor Author

Can confirm that in CI I'm seeing:

hologram @ git+https://github.com/dbt-labs/hologram.git@e4f5741c544b58e028f35296b09b3c7cdd40c4a7
jsonschema==4.17.3

@jtcohen6 jtcohen6 closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1943] Loosen pin on jsonschema (via hologram)
1 participant