Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1943] Loosen pin on jsonschema (via hologram) #6775

Closed
jtcohen6 opened this issue Jan 30, 2023 · 4 comments · Fixed by #7221
Closed

[CT-1943] Loosen pin on jsonschema (via hologram) #6775

jtcohen6 opened this issue Jan 30, 2023 · 4 comments · Fixed by #7221
Assignees
Labels
dependencies Changes to the version of dbt dependencies tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jan 30, 2023

For more context on our latest thinking around dependencies (how & why we pin today, and how we want it to change):

Summary

dbt-core depends on hologram, and as such it also includes hologram's transitive dependencies on jsonschema and python-dateutil. hologram's upper bound on jsonschema in particular is causing issues for some folks trying to install dbt-core alongside other popular tools, such as Airflow:

Short term

  • Try removing upper bound on jsonschema
  • Release a new version of hologram with no / looser upper bound
  • Support the new version of hologram in dbt-core

Medium term

Remove dbt-core's dependency on hologram entirely. It doesn't do nearly as much for us today as it used to, and the validation errors it raises aren't even all that nice.

@jtcohen6 jtcohen6 added dependencies Changes to the version of dbt dependencies tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality Team:Language labels Jan 30, 2023
@github-actions github-actions bot changed the title Loosen pin on jsonschema (via hologram) [CT-1943] Loosen pin on jsonschema (via hologram) Jan 30, 2023
@emmyoop
Copy link
Member

emmyoop commented Mar 13, 2023

Part of this will be determining how to release hologram since we have not done that recently.

@r-richmond
Copy link

Is this targeted for being included with the 1.5 release?

@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Mar 24, 2023

@r-richmond This hasn't been a top priority for us, compared to other planned work for v1.5, but I understand it's a pain for a number of folks who need to install dbt-core alongside other Python programs that require newer versions of jsonschema.

I just opened a quick PR to run CI with the latest version of jsonschema: #7219. If this "just works," we can try to sneak it in for v1.5.

Part of this will be determining how to release hologram since we have not done that recently.

@emmyoop I think it's just a manual release to PyPI.

@gshank gshank self-assigned this Mar 24, 2023
@gshank
Copy link
Contributor

gshank commented Mar 24, 2023

I've released hologram 0.0.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to the version of dbt dependencies tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
4 participants