Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check_exclude_cols option #10488

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

willmaclean
Copy link

@willmaclean willmaclean commented Jul 26, 2024

Resolves #10438

This is failing tests but that's because the dbt-adapters PR here needs merging first. If anyone has any guidance on how to get my dbt-core pointing at my dev branch of dbt-adapters so I can look at the tests, then let me know!

Problem

Want a more streamlined way of doing multi-column check strategies.

Solution

Having a check_exclude_columns option

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@willmaclean willmaclean requested review from a team as code owners July 26, 2024 12:46
@willmaclean willmaclean requested review from wpowers-dbt and removed request for a team July 26, 2024 12:46
@cla-bot cla-bot bot added the cla:yes label Jul 26, 2024
@github-actions github-actions bot added the community This PR is from a community member label Jul 26, 2024
@willmaclean
Copy link
Author

I'm also not really sure what the best way of handling the regenerated schema is.

@gshank
Copy link
Contributor

gshank commented Aug 1, 2024

Normally when we need to reference a branch in another repo we update the dev-requirements.txt file and specify it there. Then remove it when the pr is approved and we're ready to merge.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (c668846) to head (45a787e).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10488      +/-   ##
==========================================
- Coverage   88.86%   84.87%   -3.99%     
==========================================
  Files         180      180              
  Lines       22560    22648      +88     
==========================================
- Hits        20047    19222     -825     
- Misses       2513     3426     +913     
Flag Coverage Δ
integration 81.42% <62.50%> (-4.78%) ⬇️
unit 62.23% <75.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.23% <75.00%> (+0.09%) ⬆️
Integration Tests 81.42% <62.50%> (-4.78%) ⬇️

@willmaclean
Copy link
Author

Normally when we need to reference a branch in another repo we update the dev-requirements.txt file and specify it there. Then remove it when the pr is approved and we're ready to merge.

Thanks! will do this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] exclude option for check_cols snapshot
2 participants