Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] exclude option for check_cols snapshot #10438

Open
3 tasks done
Tracked by #10151
graciegoheen opened this issue Jul 12, 2024 · 5 comments · May be fixed by #10488
Open
3 tasks done
Tracked by #10151

[Feature] exclude option for check_cols snapshot #10438

graciegoheen opened this issue Jul 12, 2024 · 5 comments · May be fixed by #10488
Labels
enhancement New feature or request snapshots Issues related to dbt's snapshot functionality

Comments

@graciegoheen
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Right now snapshots have check_cols - we could add a new config for the inverse, something like check_exclude_cols.

This would be similar to the incremental model config - merge_exclude_columns

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@graciegoheen graciegoheen added enhancement New feature or request snapshots Issues related to dbt's snapshot functionality triage and removed triage labels Jul 12, 2024
@will-sylvera
Copy link

hey, if this feature is still relevant i'd be keen to have a go at it this weekend. not contributed here yet but have a bit of time and should be able to get something together

@graciegoheen
Copy link
Contributor Author

That would be great @will-sylvera! Definitely still relevant :)

@willmaclean
Copy link

willmaclean commented Jul 21, 2024

working on this now -- doing it from my personal GH account not my work one

@willmaclean
Copy link

@graciegoheen hey sorry, slightly dumb q here: whats your process for raising PRs across multiple repos? I have to make changes here and in the adapters repo here. should I just raise PRs in both places at once?

@graciegoheen
Copy link
Contributor Author

Yep! You can just raise both PRs at once, and we will review them together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request snapshots Issues related to dbt's snapshot functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants