-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devcontainer and pave the way for ingress access #106
Conversation
Again thanks for this. |
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 88.15% 88.15%
=======================================
Files 6 6
Lines 1418 1418
=======================================
Hits 1250 1250
Misses 168 168 |
@davidusb-geek, yes, but it doesn't include HA (yet :P). For now it gives you a full Python development environment that contains all the necessary dependencies to work on emhass. If you want to test it out:
|
Btw, there's a lot more that I want to improve wrt. the development flow and especially the user experience. I really want to use this add-on personally, but right now it's not quite in a state where I feel comfortable doing so. Keep in mind I'm only saying that because I'm actually willing to make the changes necessary to get to that point. I'll try to find some time this weekend to write up an issue containing my thoughts to get the discussion going. I hope you're open to this idea, @davidusb-geek? |
Thanks for these changes and the instructions to test the devcontainer. I've just merged this. |
Yes of course this is open for contribution and improvements. |
Closes: #22
The only way to see that it's working in this image is because the styles are loaded. But trust me, the buttons are working too.
This PR enables support for the Home Assistant ingress by reading the contents of the standard
X-Ingress-Path
header. This header is also used by many other reverse proxies, so this will allow them to function correctly on sub paths as well.If there's no reverse proxy in front of emhass, it will work like before, so this won't break the non-addon setup.
There are also two other changes in this PR:
I'm of course happy to remove these changes from this PR if you wish.
There will be a separate PR over at davidusb-geek/emhass-add-on that's required before the ingress actually works.