-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devcontainer and configure the add-on to support ingress #47
Conversation
Thanks for your work on this a welcome addition.
I don't think you should completely close port 5000 as that is also used for the REST API to control EMHASS., day-ahead, publish, mpc_optim including the injection of data via the REST payload. |
Good point. Makes sense to leave it open for the time being. |
Great contribution, thank you! |
@davidusb-geek done.
I don't exactly follow what you mean. Are you saying that if the user changes the port mapping inside of the add-on configuration the web server stops working? |
Yes, but the web server doesn't stop, it is just always bounded to 5000. At least this was the behavior the last time I tested this some time ago. |
That sounds like what's supposed to happen. The web server inside of an add-on should use a static port that cannot be changed (like 5000 in this case). Btw, the beauty of this system is that even if you change the external port binding you can still make use of ingress. Since all of this routing is handled by the Supervisor, the ingress can bypass any of it and always access port 5000 directly. |
Blocked by: davidusb-geek/emhass#106
This PR activates ingress for the add-on based on the changes made in the aforementioned PR.
It also adds a devcontainer specifically designed for HA add-on development.
Additionally, the following changes are made: