Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1122: Button "New request" added to "My Requests" view to improve workflow … #1123

Merged
merged 4 commits into from
Jan 1, 2024
Merged

Fixes #1122: Button "New request" added to "My Requests" view to improve workflow … #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9180f9f
Button "New request" added to "My Requests" view to improve workflow …
christian-weiss Dec 21, 2023
23d2525
Fixing an unrelated e2e test (e2e test was broken due to an external …
christian-weiss Dec 22, 2023
fc9ef50
Fix an ESLint error (#1122)
christian-weiss Dec 22, 2023
e78d443
changed implementation due to review comments (#1122)
christian-weiss Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/styles/elements.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,6 +1229,7 @@ details.footnote {
flex-wrap: nowrap;
justify-content: space-between;
margin-bottom: 15px;
column-gap: 5px;

.dropdown-container {
&:focus > .dropdown,
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/privacy-controls/company-search-page.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ describe('Search bar on company search page', () => {
cy.contains('Get access').click();

cy.get('.ais-SearchBox-input').type('twitter');
cy.contains('Twitter International Company');
cy.contains('Twitter International Unlimited Company');
});

it('is not active when the privacy control is disabled', () => {
Expand Down
11 changes: 11 additions & 0 deletions src/Components/RequestList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,17 @@ export const RequestList = (props: RequestListProps) => {
onClick={() => setSelectionMode(!selectionMode)}>
zner0L marked this conversation as resolved.
Show resolved Hide resolved
{selectionMode ? <Text id="cancel" /> : <Text id="selection-mode" />}
</button>

{!selectionMode && (
<a
id="new-request"
className="button button-secondary button-small"
href={`${window.BASE_URL}generator`}
role="button">
{t('new-request', 'generator')}
</a>
)}

{!selectionMode && (
<>
{props.importEmailsButton}
Expand Down