Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1122: Button "New request" added to "My Requests" view to improve workflow … #1123

Merged

Conversation

christian-weiss
Copy link
Contributor

…for resuming users. (#1122)

A "new request" button was added to the "my-requests" view toolbar.

Translation key "generator.new-request" was copied for all languages to "my-requests.new-request" => this way component remains depended on "my-request" scope only. No extra translation for this feature required.

Copy link

welcome bot commented Dec 21, 2023

Thank you for making your first PR on website!

We are glad about every contribution!

Feel free to add yourself to our AUTHORS file to appear as a contributor on our websites.

@christian-weiss
Copy link
Contributor Author

Looks like the end-to-end test failed because of an external change in "data repo".
datenanfragen/data@71ece3f
The update of twitter was already reviewed before being merged into master of "data repo".

I will update the e2e test according to that change.

Copy link
Member

@zner0L zner0L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that‘s a nice idea for a usability improvement! Like our bot already said, feel free to add yourself to the AUTHORS file, if you‘d like to appear as a contributor in our website.

I left you some comments I would like you to address before I merge. Good catch on the test, though! I will squash your commits when merging, so you don‘t need to worry about a clean commit history.

src/Components/RequestList.tsx Outdated Show resolved Hide resolved
src/Components/RequestList.tsx Show resolved Hide resolved
src/Components/RequestList.tsx Outdated Show resolved Hide resolved
src/Components/RequestList.tsx Outdated Show resolved Hide resolved
src/Components/RequestList.tsx Outdated Show resolved Hide resolved
@zner0L zner0L changed the title Button "New request" added to "My Requests" view to improve workflow … Fixes #1122: Button "New request" added to "My Requests" view to improve workflow … Dec 28, 2023
@christian-weiss
Copy link
Contributor Author

feel free to add yourself to the AUTHORS file, if you‘d like to appear as a contributor in our website.

I do not want to be listed as contributor. Not having me on this file is ok for me.

Copy link
Member

@zner0L zner0L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, now it looks good to me!

@zner0L zner0L merged commit e4cc8d6 into datenanfragen:master Jan 1, 2024
6 checks passed
Copy link

welcome bot commented Jan 1, 2024

Congrats on your first merge! The resulting deploy will take about twenty minutes to go live.

@christian-weiss christian-weiss deleted the 1122-add-new-request-button branch January 1, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants