-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1122: Button "New request" added to "My Requests" view to improve workflow … #1123
Fixes #1122: Button "New request" added to "My Requests" view to improve workflow … #1123
Conversation
…for resuming users. (datenanfragen#1122)
Thank you for making your first PR on We are glad about every contribution! Feel free to add yourself to our |
Looks like the end-to-end test failed because of an external change in "data repo". I will update the e2e test according to that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that‘s a nice idea for a usability improvement! Like our bot already said, feel free to add yourself to the AUTHORS
file, if you‘d like to appear as a contributor in our website.
I left you some comments I would like you to address before I merge. Good catch on the test, though! I will squash your commits when merging, so you don‘t need to worry about a clean commit history.
I do not want to be listed as contributor. Not having me on this file is ok for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, now it looks good to me!
Congrats on your first merge! The resulting deploy will take about twenty minutes to go live. |
…for resuming users. (#1122)
A "new request" button was added to the "my-requests" view toolbar.
Translation key "generator.new-request" was copied for all languages to "my-requests.new-request" => this way component remains depended on "my-request" scope only. No extra translation for this feature required.