-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vis-type: bar): grouping with zero values #598
base: develop
Are you sure you want to change the base?
Conversation
The test assertions have been changed in 1b52b4c since those are the correct value as compared to the previous changes. Previously, visyn_core/src/vis/bar/interfaces/internal/helpers/generate-aggregated-data-lookup.ts Line 87 in 4e489cc
visyn_core/src/vis/bar/interfaces/internal/helpers/generate-aggregated-data-lookup.ts Line 91 in 4e489cc
visyn_core/src/vis/bar/interfaces/internal/helpers/generate-aggregated-data-lookup.ts Line 96 in 4e489cc
visyn_core/src/vis/bar/interfaces/internal/helpers/generate-aggregated-data-lookup.ts Line 100 in 4e489cc
|
When all the values of an aggregation are Me and @thinkh discussed came to a conclusion that there is unfortunately no way to show a bar with zero width. We should show a message to the user in such a case and prompt him/her to change the aggregation type or column selected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Thank you for the changes! It looks good from my side. 👍
Added column description in the axis labels as discussed with @dvdanielamoitzi in 8d91a89 The description could be configured to show based on a new property in the config There is some clipping when there is not enough space which can be addressed by adding tooltips Also added documentation for various interfaces and enums in 2062e11 |
@dv-usama-ansari fixing a grouping issue for the barchart
Summary of changes
Screenshots
Additional notes for the reviewer(s)
Thanks for creating this pull request 🤗