Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vis-type: bar): grouping with zero values #598

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dvdanielamoitzi
Copy link
Contributor

@dv-usama-ansari fixing a grouping issue for the barchart

Summary of changes

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@dv-usama-ansari
Copy link
Contributor

dv-usama-ansari commented Oct 24, 2024

The test assertions have been changed in 1b52b4c since those are the correct value as compared to the previous changes. Previously, 0 values for globalDomain were set to ±Infinity




@dv-usama-ansari
Copy link
Contributor

dv-usama-ansari commented Oct 24, 2024

When all the values of an aggregation are 0 (not null or undefined), the bar chart does not show up since it cannot plot bars with 0 width. This happens for the following combination of configuration:

image

Me and @thinkh discussed came to a conclusion that there is unfortunately no way to show a bar with zero width. We should show a message to the user in such a case and prompt him/her to change the aggregation type or column selected

Copy link
Contributor

@dv-usama-ansari dv-usama-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Thank you for the changes! It looks good from my side. 👍

@thinkh thinkh changed the title fix(vis): barchart grouping fix(vis-type: bar): grouping with zero values Oct 25, 2024
@dv-usama-ansari
Copy link
Contributor

Added column description in the axis labels as discussed with @dvdanielamoitzi in 8d91a89

The description could be configured to show based on a new property in the config showColumnDescriptionText which defaults to false

Screenshot from 2024-10-25 11-34-34

There is some clipping when there is not enough space which can be addressed by adding tooltips
Screenshot from 2024-10-25 11-35-53

Also added documentation for various interfaces and enums in 2062e11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants