Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar plot maintenance #596

Open
dv-usama-ansari opened this issue Oct 24, 2024 · 6 comments
Open

Bar plot maintenance #596

dv-usama-ansari opened this issue Oct 24, 2024 · 6 comments
Assignees

Comments

@dv-usama-ansari
Copy link
Contributor

dv-usama-ansari commented Oct 24, 2024

Coming from #563

Please see comments for more details

@dv-usama-ansari dv-usama-ansari added the type: bug Something isn't working label Oct 24, 2024
@dv-usama-ansari
Copy link
Contributor Author

#563 (comment)

Spacing between axis label and ticks

563-axis-label-spacing

@dv-usama-ansari
Copy link
Contributor Author

#563 (comment)

Clipped tooltip for very wide graph

image

@dv-usama-ansari
Copy link
Contributor Author

#563 (comment)

Missing legend

image

@dv-usama-ansari
Copy link
Contributor Author

dv-usama-ansari commented Oct 24, 2024

#563 (comment)

Bar plot for a group column containing all null values for this session:

Image

Discussion with @thinkh: We should show #71787E Unknown item in the legend and the tooltip

@dv-usama-ansari dv-usama-ansari self-assigned this Oct 24, 2024
@dv-usama-ansari
Copy link
Contributor Author

#598 (comment)

When all the values of an aggregation are 0 (not null or undefined), the bar chart does not show up since it cannot plot bars with 0 width. This happens for the following combination of configuration:

image

Me and @thinkh discussed came to a conclusion that there is unfortunately no way to show a bar with zero width. We should show a message to the user in such a case and prompt him/her to change the aggregation type or column selected

@dv-usama-ansari
Copy link
Contributor Author

Comments with @thinkh following the discussion of #596 (comment):

-Survival months filters out the 0 for all the aggregation.

  • Show 0 for all the aggregation other than count.

-Tumor size has null across all categories of breast surgery type

  • Filter out null and the non-null-minimum is the minimum value

  • Add documentation for decisions made

@dv-usama-ansari dv-usama-ansari added type: technical debt Describes or removes a technical debt vis-type: bar feature: general improvements and removed type: bug Something isn't working labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant