Change the "endmarker" logic of the SSHRemoteIO shell
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation did not make sure that an endmarker (that is expected to occur on a dedicated line) could be dedicated. This was because a command whose output did not end with a newline would leave residual content that prevented this detection. This changeset modifies the nature of the endmarker such that a newline is unconditionally present. Closes #86 Closes #87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation did not make sure that an endmarker (that is
expected to occur on a dedicated line) could be dedicated. This was
because a command whose output did not end with a newline would leave
residual content that prevented this detection.
This changeset modifies the nature of the endmarker such that a newline
is unconditionally present.
Closes #86
Closes #87