Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSHRemoteIO.read_file() unreliable with missing newline #86

Closed
mih opened this issue Sep 21, 2023 · 0 comments · Fixed by #90
Closed

SSHRemoteIO.read_file() unreliable with missing newline #86

mih opened this issue Sep 21, 2023 · 0 comments · Fixed by #90

Comments

@mih
Copy link
Member

mih commented Sep 21, 2023

#85 revealed that it can hang in such cases. The contained test documents a behavior that works and one that does not.

It is unlikely that the problem has a simple solution. In isolation reading files without newlines works. However, after some other operations (that all run in the same shell session), this becomes possible.

It is possible that the whole shell sessions is in some ill-conditioned state at that point.
mih added a commit that referenced this issue Sep 21, 2023
@mih
TMP Add patch
aab251e 
Closes #86
Closes #87
@mih mih changed the title SSHRemoteIO.read_file() unreilable with missing newline SSHRemoteIO.read_file() unreliable with missing newline Sep 21, 2023
mih added a commit that referenced this issue Sep 21, 2023
@mih
Extend test to document wrong handling of missing newlines in cmd output
ec6d324 
See #86 and #87
mih added a commit that referenced this issue Sep 21, 2023
@mih
Change the "endmarker" logic of the SSHRemoteIO shell
196246e 
The previous implementation did not make sure that an endmarker (that is
expected to occur on a dedicated line) could be dedicated. This was
because a command whose output did not end with a newline would leave
residual content that prevented this detection.

This changeset modifies the nature of the endmarker such that a newline
is unconditionally present.

Closes #86
Closes #87
@mih mih mentioned this issue Sep 21, 2023
Merged
mih added a commit that referenced this issue Sep 21, 2023
@mih
Change the "endmarker" logic of the SSHRemoteIO shell
7db5ebc 
The previous implementation did not make sure that an endmarker (that is
expected to occur on a dedicated line) could be dedicated. This was
because a command whose output did not end with a newline would leave
residual content that prevented this detection.

This changeset modifies the nature of the endmarker such that a newline
is unconditionally present.

Closes #86
Closes #87
@mih mih closed this as completed in #90 Sep 21, 2023
mih added a commit that referenced this issue Sep 21, 2023
@mih
Extend test to document wrong handling of missing newlines in cmd output
1d72795 
See #86 and #87
mih added a commit that referenced this issue Sep 21, 2023
@mih
Change the "endmarker" logic of the SSHRemoteIO shell
30c3fd9 
The previous implementation did not make sure that an endmarker (that is
expected to occur on a dedicated line) could be dedicated. This was
because a command whose output did not end with a newline would leave
residual content that prevented this detection.

This changeset modifies the nature of the endmarker such that a newline
is unconditionally present.

Closes #86
Closes #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the "endmarker" logic of the SSHRemoteIO shell datalad/datalad-ria
1 participant
@mih