Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OutputFrom class as iter_subproc result, which keeps returncodes on exception #565

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Use OutputFrom class as iter_subproc result, which keeps returncodes on exception #565

merged 2 commits into from
Dec 13, 2023

Commits on Dec 12, 2023

  1. convert generator-function into generator 

    This commit converts the generator function
`output_from` into an instance of a the
generator class `OutputFrom`.

The rationale for this conversion is that
the generator class can store the
return code of the subprocess as attribute.
Thus the returncode is available, even
if an exception is raised within the
`iterable_subprocess`-context.
    @christian-monch
    christian-monch committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    df9bd73 View commit details
    Browse the repository at this point in the history

  2. add basic tests for returncode-attribute 

    This commit adds some basic tests to verify
that the `returncode` attribute of the
`iterable_subprocess` generator is properly
set.
    @christian-monch
    christian-monch committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    a6928b3 View commit details
    Browse the repository at this point in the history