Use OutputFrom class as iter_subproc result, which keeps returncodes on exception
#565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
+ Coverage 92.88% 92.90% +0.01%
==========================================
Files 143 143
Lines 10379 10411 +32
Branches 1145 1148 +3
==========================================
+ Hits 9641 9672 +31
- Misses 714 715 +1
Partials 24 24 ☔ View full report in Codecov by Sentry. |
christian-monch
force-pushed
the
keep_returncode_on_exception
branch
2 times, most recently
from
89c966c
to
06952f1
Compare
This commit converts the generator function `output_from` into an instance of a the generator class `OutputFrom`. The rationale for this conversion is that the generator class can store the return code of the subprocess as attribute. Thus the returncode is available, even if an exception is raised within the `iterable_subprocess`-context.
This commit adds some basic tests to verify that the `returncode` attribute of the `iterable_subprocess` generator is properly set.
christian-monch
force-pushed
the
keep_returncode_on_exception
branch
from
06952f1
to
a6928b3
Compare
This was referenced Dec 12, 2023
mih
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a solution for the problem of not-easily available return codes that was discussed here in PR #546.
This is an alternative (and in my view superior) approach to the discussed solution, which is implemented in PR #562.
The reason why this second approach exists is:
StopIterationin PR HandleStopIterationiniterable_subprocess#562)iter_subproc, i.e. inSshUrlOperations.